QR Code Component | HTML CSS

Community feedback

• 

  Mohmed elshaarawy•830

  @MohmedElshaarawy

  Posted over 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page. Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information. Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io CSS 🎨:

  Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘. Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport. I hope you find it useful! 😄

  Happy coding!

  01

  Marked as helpful
• 

  P

  Darrick Fauvel•490

  @DarrickFauvel

  Posted over 3 years ago

  Hi @vanzasetia, 👋

  Great job! 🎉

  The only things I can see are slight font size and line height issues. I don't know if you've ever tried the :root { font-size: 62.5% } trick? I use it all the time (until someone tells me a better way). It sets up all of your rem font sizing to be 1rem = 10px. So, a 25px font from Figma would be equal to 2.5rem.

  As for line height, I have been using the calc() function to do the math for me. I get the pixel line height from Figma, say 28px for the heading, divide it by the heading pixel font size of 22px, and the result will be a number.

  So, in this challenge try this:

  :root {
    font-size: 62.5%;
  }
  .card__title {
    font-size: 2.2rem;
    line-height: calc(28 / 22);
  }
  .card__description {
    font-size: 1.5rem;
    line-height: calc(19 / 15);
  }
  

  📒Note: It will throw off your other sizes based on the root font size. So, you would adjust accordingly.

  I hope this helps! 😊

  15