Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component - HTML, CSS, Flexbox, Grid

@christopherbeech

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcome.

Community feedback

Kehindeβ€’ 660

@jonathan401

Posted

Congrats on completing this challenge πŸŽ‰πŸŽ‰. You did a really good job πŸ˜‡. Just a few things though.

  1. For some reason you created two branches on your repo 'main' and master branch πŸ€”. You could consider moving your code to the main branch and getting rid of the master branch πŸ˜‰ this will make it easier for other developers to find your code and give you helpful feedback πŸ˜‡. You could check out this YouTube tutorial by The NetNinja on YouTube to better understand how Git and GitHub works πŸ’ͺ
  2. You should consider wrapping your card with a main element instead of a div. This will help make your html markup more semantic and easy for additive technologies like screen readers to easily navigate your site/page.
  3. It is required by the WCAG guide that every page contain one h1 element. This will again, make your html markup semantic as well as make it easy for people with disabilities to easily navigate your page/site.
  4. To easily center your card on the screen you could consider adding the rule to your body selector: display: flex; justify-content: center; align-items center; min-height: 100vh; The min-height: 100vh; style rule is to make sure that the body element takes at the entire screen height and makes it easy for thecss flex rule to work. If you're more comfortable using the CSS Grid, you could use the rule display: grid; place-items: center; πŸ˜‡. I guess that's the feedback I could provide ☺️. Once again congrats on completing this challenge πŸŽ‰πŸŽ‰. Happy coding πŸŽ‰πŸŽ‰

Marked as helpful

1

@christopherbeech

Posted

@jonathan401 Thank you! I really appreciate the feedback πŸ˜€.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord