Kehindeβ’ 660
@jonathan401
Posted
Congrats on completing this challenge ππ. You did a really good job π. Just a few things though.
- For some reason you created two branches on your repo 'main' and master branch π€. You could consider moving your code to the main branch and getting rid of the master branch π this will make it easier for other developers to find your code and give you helpful feedback π. You could check out this YouTube tutorial by The NetNinja on YouTube to better understand how Git and GitHub works πͺ
- You should consider wrapping your card with a
main
element instead of a div. This will help make your html markup more semantic and easy for additive technologies like screen readers to easily navigate your site/page. - It is required by the WCAG guide that every page contain one h1 element. This will again, make your html markup semantic as well as make it easy for people with disabilities to easily navigate your page/site.
- To easily center your card on the screen you could consider adding the rule to your body selector:
display: flex; justify-content: center; align-items center; min-height: 100vh;
Themin-height: 100vh;
style rule is to make sure that the body element takes at the entire screen height and makes it easy for thecss flex rule to work. If you're more comfortable using the CSS Grid, you could use the ruledisplay: grid; place-items: center;
π. I guess that's the feedback I could provide βΊοΈ. Once again congrats on completing this challenge ππ. Happy coding ππ
Marked as helpful
1
Christopher Beechβ’ 10
@christopherbeech
Posted
@jonathan401 Thank you! I really appreciate the feedback π.
1