Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

QR code component HTML/CSS

styled-components
Kathy Sandoval•10
@kathyale7
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my first project, any feedback is welcome!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Danilo Blas•6,300
    @Sdann26
    Posted about 3 years ago

    Hi Kathy!

    I would recommend changing the text size.

    .text p {
      color: #9699a0;
      padding: 0 8px;
      font-size: 16px;
    }
    

    I know that in style-guide.md says 15px but for your design I think that if you put 16px it looks the same.

    Leaving aside the design I recommend you always examine the error reports that frontend mentor generates. In this case <div class="rectangle"> you should change it to <main class="rectangle"> since you always need to have only one main per project inside the body because it contains all the central content of the page.

    Following with the report you should always add the alt="" attribute in the images like <img src="images/image-qr-code.png" alt="QR Code"> because it helps people who use screen readers ie blind people for example because the screen reader is in charge of interpreting these images.

    You should also change <h2>Improve your front-end skills by building projects</h2> to <h1>Improve your front-end skills by building projects</h1> because like the main you should always have one per page since it is the title of the page and the other h2, h3,.... function as subtitles one of the other and so as if it were a report.

    I hope my comments are helpful for you, all these accessibility issues must always be taken into account.

    Good luck :D!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub