Oops! You need to be logged in to do that
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Oops! You need to be logged in to do that
Not Found
Oops! You need to be logged in to do that
Not Found
Not Found
Not Found
Not Found
Oops! You need to be logged in to do that

Submitted

QR code component HTML/CSS

#styled-components

@kathyale7

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View Challenge

Design Comparison

SolutionDesign

Report

4

Accessibility Issues

1

HTML Issues

View Report

Kathy Sandoval’s questions for the community

This is my first project, any feedback is welcome!

Community Feedback

Danilo Blas 6,360

@Sdann26

Posted

Hi Kathy!

I would recommend changing the text size.

.text p {
  color: #9699a0;
  padding: 0 8px;
  font-size: 16px;
}

I know that in style-guide.md says 15px but for your design I think that if you put 16px it looks the same.

Leaving aside the design I recommend you always examine the error reports that frontend mentor generates. In this case <div class="rectangle"> you should change it to <main class="rectangle"> since you always need to have only one main per project inside the body because it contains all the central content of the page.

Following with the report you should always add the alt="" attribute in the images like <img src="images/image-qr-code.png" alt="QR Code"> because it helps people who use screen readers ie blind people for example because the screen reader is in charge of interpreting these images.

You should also change <h2>Improve your front-end skills by building projects</h2> to <h1>Improve your front-end skills by building projects</h1> because like the main you should always have one per page since it is the title of the page and the other h2, h3,.... function as subtitles one of the other and so as if it were a report.

I hope my comments are helpful for you, all these accessibility issues must always be taken into account.

Good luck :D!

Marked as helpful

1


@kathyale7

Posted

@Sdann26 Thank you! That is quite helpful.

0

Danilo Blas 6,360

@Sdann26

Posted

@kathyale7 Por cierto recien me di cuenta que hablas español hahaha. Apenas corrijas esos detalles genera un nuevo reporte a ver si sale con 0 errores.

Cualquier consulta me la haces por aquí o por Linkedin!

0

Please focus on giving high-quality, helpful feedback and answering any questions kathyale7 might have. Here are some key points to consider:

  • Does the solution include semantic HTML?
  • Is it accessible, and what improvements could be made?
  • Does the layout look good on a range of screen sizes?
  • Is the code well-structured, readable, and reusable?

You can read our community guidelines if you're unsure what to post.

Slack logo

Join our Slack community

Join over 100,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!