QR code component HTML/CSS

Community feedback

• 

  Danilo Blas•6,300

  @Sdann26

  Posted about 3 years ago

  Hi Kathy!

  I would recommend changing the text size.

  .text p {
    color: #9699a0;
    padding: 0 8px;
    font-size: 16px;
  }
  

  I know that in style-guide.md says 15px but for your design I think that if you put 16px it looks the same.

  Leaving aside the design I recommend you always examine the error reports that frontend mentor generates. In this case <div class="rectangle"> you should change it to <main class="rectangle"> since you always need to have only one main per project inside the body because it contains all the central content of the page.

  Following with the report you should always add the alt="" attribute in the images like <img src="images/image-qr-code.png" alt="QR Code"> because it helps people who use screen readers ie blind people for example because the screen reader is in charge of interpreting these images.

  You should also change <h2>Improve your front-end skills by building projects</h2> to <h1>Improve your front-end skills by building projects</h1> because like the main you should always have one per page since it is the title of the page and the other h2, h3,.... function as subtitles one of the other and so as if it were a report.

  I hope my comments are helpful for you, all these accessibility issues must always be taken into account.

  Good luck :D!

  12

  Marked as helpful