Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

QR code component

itcss
Devesh•120
@devesht21
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


First try! How is it? What are the mistakes that I should not repeat next time?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jaimie Warburton•90
    @Fazyyy
    Posted over 3 years ago

    Not really a criticism but just an option for next time, your parent section with the class "section-qr" seems to only provide the functionality of making the background color full screen. Next time maybe consider applying the background color to the body element and giving it the css attribute of min-height:100vh;

    As others ahve pointed out, using a "main" element rather than a "section" would have been more appropriate.

    Marked as helpful
  • Travolgi 🍕•31,300
    @denielden
    Posted over 3 years ago

    Hi Devesh, I took some time to look at your solution and you did a great job!

    Also add main tag and wrap the card for Accessibility and remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image

    Overall you did well :)

    Hope this help and happy coding!

    Marked as helpful
  • J•1,020
    @jrmy-dev
    Posted over 3 years ago

    Hi! Well done!

    If this can help, I have a suggestion:

    • Fix accessibility issues: to do so, change your <section class="section-qr"> to <main class="section-qr">.

    If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub