Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

QR Code Component

Matthew Marshall•80
@marsh189
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

As this was a beginner challenge, I am happy I never got that stuck and was able to set up the basic format without any issues.

What challenges did you encounter, and how did you overcome them?

My main issue, and what is usually my issue is getting the sizing and responsiveness correct. I was able to size it so that it will fit both desktop and mobile devices without issue, however I would like to make it more responsive for different screen sizes.

What specific areas of your project would you like help with?

I would like to get better at understanding how to create responsive websites. I also would like to know what the best solution to sizing the image was. I found that setting max-width to '-webkit-fill-available' got it to fit as I wanted it to, but I do not know if this is the best way to go about it. Should it just have a set height and width?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Advyta Jujaray•170
    @Advyta
    Posted about 1 year ago

    Hello there, Congratulations on completing this project

    There are some best practices that you should consider while creating responsiveness in your website.

    1. Mobile-First Approach: Start your design with mobile screen in mind and then scale up for larger devices
    2. Use Media Queries: Media queries allow you to define different breakpoints for your website, helping you specify different CSS properties based on the size of the user’s screen
    3. Relative Units: Try to use relative units like ‘vh’, ‘vw’, and ‘%’ instead of fixed pixels. This ensures that elements resize components according to the screen size
    4. CSS Flexbox or Grid: These are modern CSS features that can be used for creating responsive layouts. They make planning website layouts easy

    You can learn responsive design in detail from here W3School or Introduction To Responsive Web Design - HTML & CSS Tutorial

    Now regarding sizing the image in your code max-width: -webkit-fill-available property you used is a WebKit-specific property that might not work in all browsers. You can instead use max-width: 100% and height: auto for your images. This makes the image responsive and scales it down if necessary, but never scales it up to be larger than its original size. You can modify your .qr class like this:

    .qr {
      border-radius: 20px;
      max-width: 100%;
      height: auto;
    }
    

    Also consider using semantic HTML tags like <main></main>, <section></section> and others that you can find in this link. The main tag should hold the main content of the page and you can divide the content into sections. The semantic HTML tags help the search engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read and offers a better user experience. It has greater accessibility. Using div when there's a better alternative is not a good practice as div hold no semantic value.

    I hope this feedback is helpful

    Other than that good job!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub