@PhoenixDev22
Posted
Hi Thanuja Fernando,
Excellent work! I have some suggestions regarding your solution:
Consider using min-height: 100vh
instead of height: 100%
to the body , that let the body grows taller if the content of the page outgrows the visible page.
- An explicit width is not a good way to have responsive layout . Consider using
max-width
to the card inrem
.
- Remember a modern css reset on every project that make all browsers display elements the same. Set the image to display: block as there is a little gap under the image , you can see it when use devtools.
- Consider using rem for font size , it' not recommended to use px for font size as absolute units don’t scale for example 15px will always be 15px on the same device. Using pixels is a particularly bad practice for font sizing because it can create some accessibility problems for users with vision impairments.
Links must have discernible text also Check the footer's link , there are two nested links.
After , you fix the issues, you can generate another report for your solution.
Hopefully this feedback helps.