QR-code-component

Solution retrospective
this is my second challenge here and any constructive feedbacks are welcome so i can improve my coding thank you
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Hassiai
add the alt attribute
alt=" "
to the img tag and <h3> with <h1> to fix the accessibility and error issues. the value of the alt is the description of the image.For a responsive content which wont require a media query for this challenge, replace the width of .cart with max-width and give it a fixed value. e.g:
max-width:350px;
. There is no need for a height value .cart , the padding value can be a replacement of that and it a responsive replacement.Give the img a max-width of 100% instead of a width height value , there is no need for a margin value in the img.
There is no need for margin value in .text, increase the padding vale and add a font-size of 15px to it , this will reduce the font-size of h1 and p.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord