Skip to content
Submitted over 1 year ago

QR Code Component

Joey•10
@joelbaah
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Unsure about the attribution styling.

Open to suggestion on how I can improve my overall code & best practices.

Thanks!

Code

Please log in to post a comment

Log in

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055

    Hello Coder 👋

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    • Don't use position or margins for centering the card as it will not dynamically center the card remove this and use either flex or grid for the same
    .qrcard {
    /* position: relative; */
    /* top: 50%; */
    /* left: 50%; */
    /* transform: translate(-40%,40%); */
}
    • To properly center the card
    • USING FLEXBOX
    body{  
    display: flex;
    justify-content: center;
   align-items: center;
   min-height: 100vh;
   ...
}

    • Every site must have one h1 element describing the main content of the page.

    • So, Add a level-one heading

    • <h1>Improve you frontend skills by building projects</h1>

    • Use Semantics for the proper design of your code.

    <body>
<main>... main content goes here ...</main>
<footer>... .attribution div goes here ... </footer>
</body>

    • For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".

    • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord