Solución Card-QR

Community feedback

• Account deletedPosted over 2 years ago

  Hey there! 👋 Welcome to FEM and congrats on completing your first challenge!🎊🍻

  Here are some suggestions to help improve your code:

  • Avoid skipping heading levels ⚠️. Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the heading’s level of importance.

  • The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • NEVER ❌ do this as it creates accessibility issues for users and it is outdated, instead download a px to rem/ em converter in your code editor.

  html {
    font-size: 62.5%;
  }
  

  • Change ⚠️ width to max-width in your component’s container to make it responsive. You will also want to remove the height as it is unnecessary.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  00

  Marked as helpful
• 

  Javier•40

  @Kritical719

  Posted over 2 years ago

  Very good code just remember to put first a H1 you need a title, cheers

  00

  Marked as helpful