Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr code component main

#tailwind-css#node
Aman Khan 10

@AmanAdastra

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Basic Project but it always good to have a strong foundation.

Community feedback

P
Fluffy Kas 7,735

@FluffyKas

Posted

Heyo,

Your solution looks nice! There's a few small things you could check though.

  • your QR code image is missing its alt text
  • Regarding Tailwind: there are built-in Tailwind classes for both of these: h-[100%] and h-[100vh], these would be h-full and h-screen if I recall correctly. but heights shouldn't really be fixed anyway, so a min-h-full/min-h-screen would be better suited.
  • bg-[#d5e1ef] => Things like colours or other variables that you may reuse in the future should be ideally set in the tailwind config file

All in all, good job on this one!

1

Aman Khan 10

@AmanAdastra

Posted

Thanks @FluffyKas. Your Feedback is much appreciated.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord