qr-code-component-main

Community feedback

• 

  Hrid Chakraborty•70

  @hrid-chakraborty

  Posted 9 months ago

  I would like to start by saying that you have built the QR component really well.

  Here are some observations/suggestions which I hope are helpful:

  1. When opening the website, the card appears on the bottom middle section of the page instead of the center.
  2. When resizing the window, the card is appearing on the left of the page. (Hint: both these problems can be solved using flexbox )
  3. It would be best practice to put the styles in a separate .css file. Improves code readability.
  4. Just a small nitpick, but it would look much nicer if some more padding is added inside the card. Also, you could use custom fonts (like Outline from style-guide.md) from Google fonts.

  Overall, the component looks really nice. I hope my feedback has been helpful.

  00