Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

QR Code Component Main

Gustavo de Camargo Campos•200
@themegazord
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Fala Gustavo, beleza? Parabéns pela sua solução!

    Dei uma olhada na sua solução aqui e ficou muito boa! Meu conselho seria só reduzir um pouco a estrutura de html, usando uma só div pra segurar tudo e colocar cada elemento solto lá, pq vc consegue controlar tudo com uma div só e cada elemento separado, olha a estrutura abaixo:

    <body>
    <main>
    <img>
    <h1></h1>
    <p></p>
    </main>
    </body>
    

    Pra deixar o container responsivo, você tem que arrumar a imagem com display: block e max-width: 100% desse jeito a imagem diminui acompanhando o component e nem precisa dar um tamanho pra ela, já que ela vai ser 100% do container menos o padding.

    Em relação ao border-radius é melhor não usar porcentagem porque é uma unidade relativa e a borda vai variar quando o container escalar, ao invés disso use 12px

    .content {
        border-radius: 12px;
        max-width: 20rem;
    }
    
    .img__container img {
        display: block;
        /* width: 18rem; */
        border-radius: 5%;
        max-width: 100%;
    }
    

    Espero ter ajudado e continue no foco!

    Marked as helpful
  • Gustavo de Camargo Campos•200
    @themegazord
    Posted almost 3 years ago

    Fala aí, Lucas, tudo sim e com você?

    Então cara, eu estou começando agora no front-end, estou me adaptando ao full-stack, visto que já sou back-end e no momento eu tenho mais segurança separando tudo por div, mas com o tempo vou separando as coisas para ter apenas uma div.

    Muito obrigado pelo feedback, vou tentar nos próximos desafios para tentar fazer isso que você disse.

    Fique bem :-)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub