Skip to content
Submitted 8 months ago

qr-code-component-main

ali3nbtw•80
@ali3nbtw
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • P
    Steven Stroud•11,910
    @Stroudy

    Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

    * {
	box-sizing: border-box;
	margin: 0;
	padding: 0;
	font-family: 'Outfit', sans-serif;
}
    • Using rem or em units in @media queries is better than px because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.
    @media screen and (max-height: 700px)
    • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

    I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

    Marked as helpful
  • P
    Steven Stroud•11,910
    @Stroudy

    It looks like your Repository is set to private 🔏 so we are unable to provide some feedback on your code, You can change this following these steps,

    1. Open up your repository on Github, ✅
    2. Click on settings on the top nav bar, ✅
    3. Scroll down to the bottom, ✅
    4. In the red box you will see change repository visibility ✅
    5. Click on on Change visibility and select public. ✅

    Once you have done this your GitHub link should be viewable by everyone here on Frontend Mentor.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord