Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

QR code component

Kristin Brooks•40
@kristinbrooks
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


My first time making something like this without a tutorial. Now I just need tons more practice. 😂

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Danilo Blas•6,300
    @Sdann26
    Posted about 3 years ago

    Congratulations on finishing your first frontend mentor project Kristin!

    Whenever you finish a challenge I always recommend that you review the bug report that frontend mentor generates because it helps you fix bugs that may be more difficult to detect in the future. In your case we see that you have some accessibility errors that can be easily fixed by doing the following:

    • Change <div class="qr-component"> to <main class="qr-component">.
    • Change <div class="attribution"> to <footer class="attribution">.
    • Change <p class="text-lg"> to <h1 class="text-lg">.

    In the first two cases these are landmark tags that serve to encompass large sections of the project. You should always have a main with the main flow of the project while the footer is more for the bottom section of the projects that usually have one or another detail like links to social networks, the disclaimer, some navigation links, etc.

    By the way you should always have a single h1 at first instance you will see that the title of the page should not be the title of the card because it works as a component that will be repeated on several occasions but if you change it will serve you so that at least in this project will not give you any accessibility problem.

    And that's all I hope my comment can help you, my pleasure!

  • Nigel•100
    @nigelvidaaal
    Posted about 3 years ago

    Job well done, Kristin! Can I ask what exactly did you do for this project to be so accurate? (like the dimensions and sizes), thanks in advance!

  • P
    Sabbir Ahmed•930
    @sabbircoder07
    Posted about 3 years ago

    Well Done. Best Wishes For You.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub