qr code component using basic CSS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted over 2 years ago

  Hello there 👋. Congratulations on completing this challenge!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • To center an element vertically, you should use a height to its container. In this case it is recommended to use "min-height: 100vh" so that it occupies 100% of the graphical height. e.g.: .container { min-height: 100vh; }

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  21

  Marked as helpful
• 

  Hassia Issah•50,390

  @Hassiai

  Posted over 2 years ago

  Replace <div class="container"> with the main tag to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  11

  Marked as helpful