QR code component

Community feedback

• 

  P

  Øystein Håberg•13,280

  @Islandstone89

  Posted 8 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Change .container to a <main>.

  • You don't need to wrap the image in a <div>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Make a habit of including a proper CSS Reset at the top of the stylesheet.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Move font-family to body, and remember to specify fallback fonts: font-family: 'Outfit', system-ui, sans-serif;

  • .container doesn't need any styles, so move those to .card.

  • Remove the margin on the card. Instead, add justify-content: center on the body, to center the card horizontally.

  • max-width on the card should be in rem. Around 20rem works well.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • On the image, add display: block, height: auto and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  11

  Marked as helpful