Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component responsive solution mobile-first

@LucasdeAndres

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I don't have any particular question but every optimizing tip or advise is always welcome :)

Community feedback

Tux3er 760

@Tux3er-Isma

Posted

Hi Lucas!!!

Congrats completing this challenge, and also for your awseome code 😉🎉!!!

I will give you some tips for your next project 💡:

  • In your .gitignore file I recomendyou to put the .vscode folder

  • To get a better semantic, you should replace the <div></div> element for a <main></main> tag

  • Try to use a css reset, I recomend you the normalize.css 🎨

  • Also I recomend you to put variables in css. You can put it in :root{} in css. There is some documentation if you want to practice css variables. Documentation 📖

  • Also create a custom Readme.md file. In this file you can put the tecnologies you used to build this project.

That's all. I hope this comment will be helpful for you in the future 😉👍🏻

Happy coding ⌨️🖐🏻 Lucas !!!

Marked as helpful

2

@LucasdeAndres

Posted

@Tux3er-Isma Thanks for the feedback, Ismail. I will try to implements these tips on the next project. In the case of the .gitignore putting .vscode in the file is enough?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord