qr-code-component-responsive-transition-boxShadow

Community feedback

• 

  P

  umwebdev•20

  @umwebdev

  Posted 7 months ago

  Hey Hamed, Good job on your first challenge, however there is a lot of room for improvement. I would break everything down into bullet points for you so its easier to implement these changes

  • Try giving meaningful classnames to the elements, it would save a lot of time when you are revisiting the code after a few days or weeks

  • don't add height to an element explicitly, this would introduce overflow issues when the content gets larger than the height you have mentioned

  • when you need spacing inside an element, try giving padding to the parent element instead of giving margins to the children elements

  • instead of giving margin-top to the second element, give margin bottom to the first element. This would keep the spacing even when you delete the second element.

  • learn and use css variables, or custom properties. that would save you ton of time, here's a video that'll help you quickly grasp the css variables https://www.youtube.com/watch?v=NtRmIp4eMjs

  • try using rem instead of pixels,, here's a great tutorial on learning the html css fundamentals by john smilga aka coding addict, it has time stamps for you to navigate easily https://www.youtube.com/watch?v=-8ORfgUa8ow

  I know that's a lot of suggestions, kindly don't get overwhelmed and take your time to implement those, it took me months to grasp all those concepts and the tutorial from john smilga is superb to learn the fundamentals.

  00
• 

  Gildman Laécio•180

  @gillaercio

  Posted 7 months ago

  In my eyes it's practically the same. But as my colleague said, being detail-oriented is a crucial objective for our line of work.

  00