@correlucas
Posted
πΎHi @nemesisaquib, congratulations on your first solution!
*βve few suggestions for you that you can consider adding to your code:
1.Replace the <h2>
containing the main title with <h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
2.Use relative units as rem
or em
instead of px
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.
3.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>
. For this solution you wrap everything inside a single block of content using <div>
or <main>
(better option for accessibility) and put inside the whole content <img>
/ <h1>
and <p>
.
<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
βοΈ I hope this helps you and happy coding!
Marked as helpful
@nemesisaquib
Posted
@correlucas thank you so much sir your feedback and I remember this I am still th learning rm and rem properties and I will remove unnecessary elements thank you so much ππ
@nemesisaquib
Posted
@correlucas yes sir it help me so much thanks a lot sir