Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

QR Code Component - Samuel Santa

Samuel Santa•10
@dvsanta
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi! This is my first Frontend Mentor Challenge.

Please provide me any Feedback, everything is welcome.

I have questions about the folders methodology. Is it correct?

Thanks

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vanza Setia•27,715
    @vanzasetia
    Posted over 2 years ago

    Hi, Samuel Santa! 👋

    For the project structure, I recommend keeping it simple. You don't need a src/ folder. You should use src/ folder when you are using a bundler such as Parcel.

    Put the HTML code for the site in the root folder. Don't put it inside another html/ folder. For the CSS, I recommend putting it in the root folder too.

    If you have more than one CSS file, let's say the minified for the production and the formatted code for the code review, then I recommend having a css/ folder in the root.

    The same goes for other types of file such as images and scripts.

    But, what I am saying here is just a guide. It is not an absolute rule to follow. The point is to keep your project structure as simple as possible.

    You can see my repository of this project as an example, vanzasetia/qr-code-component: A simple challenge by Frontend Mentor that boosts my motivation.

    For the code feedback, you should remove the srcset attribute from the <img>. It is empty.

    I hope this helps. Happy coding! 😄

    Marked as helpful
  • Sumanth Chandana•720
    @sumanth-chandana
    Posted over 2 years ago

    **Hi mate! congrats on completing the challenge. I have a suggestion for you:

    • The role attribute on an HTML element specifies the semantic meaning or purpose of the element for accessibility purposes. However, the value "card" is not a valid option for the role attribute. The role attribute has a predefined set of values that describe the roles of different elements, and "card" is not one of them.

    I hope this resolves your error.

    Marked as helpful
  • Anei•30
    @aneimalieny
    Posted over 2 years ago

    Nice code mate, I would just say make the HTML more semantic in a way that screen readers would easily understand and interpret the HTML. Margin below the text might be too big, reduce it abit too.

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted over 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

    • So fix it by replacing the <div class="card"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

    • For example:
      • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
      • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

  • Abraham•270
    @Abeeujah
    Posted over 2 years ago

    Hello, you submitted a nice solution and Here's some helpful tips to help you improve it

    HTML :

    Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

    Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub