@correlucas
Posted
👾Hi @MelvinAguilar, congratulations on your solution!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
1.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.
2.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.
3.Add <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
Marked as helpful
@MelvinAguilar
Posted
@correlucas Thanks for the feedback! I will definitely take it into account in my next challenges!
@Frank2522
Posted
@correlucas please sir how can I submit my project
@MelvinAguilar
Posted
Hi @Frank2522, I'm not correlucas but I saw your comment, Here is an complete guide to submitting solutions: https://medium.com/frontend-mentor/a-complete-guide-to-submitting-solutions-on-frontend-mentor-ac6384162248
The full summary of creating and publishing your solution is:
- Accept the challenge
- Create a public repository in GitHub to share your code with the community
- Build your project
- Deploy your project
- Submit your solution
