Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 8 months ago

Qr code component solution

pcamp44•10
@pcamp44
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • jeevan-v-jijo•80
    @jeevan-v-jijo
    Posted 8 months ago

    You have done a great job completing this task. Congrats!

    Padding:

    The container had the padding-top set to 1% and the left and right padding is done by the image width:90% which can change with different screen sizes. This makes the padding inconsistent. I would suggest of giving a padding: 16px 16px 40px 16px for the container since that is what can be inferred from the Figma file.

    Semantics

    The element of the class container could have been given the <main> instead of a generic <div>. This adds extra meaning for the code and help the users with accessibility features like screen readers.

    These are my suggestions feel free to correct me if I am wrong

    Marked as helpful
  • P
    Jeronimo Palacios•300
    @giropa832
    Posted 8 months ago

    Nice solution. I'd like to give you some feedback.

    • Was using media queries necessary? the solution does not match the designs in desktop mode.
    • Was absolute positioning the best approach? While the screenshot seems to be correct, maybe implementing a solution with flexbox could be more appropiate.
    • I liked the fact that you rooted colors. It makes refactoring so much easier!
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub