Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component solution

@mohamedkhaled4053

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


can I have feedback about this solution?

Community feedback

@StormKing969

Posted

Hi,

I took some time to look at your solution and you did a great job!

The only thing I would have done differently would be grabbing the p tag using p:first-of-type and p:last-of-type. Instead, I would have used a span tag and given them a class name (or given the p tag a class name)

That way when I go back to my CSS file, I know the exact tag I targeting but that's just my personal preference

Another thing is that I'll take a look at the Semantics in HTML when structuring your HTML content

Have a nice day & Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord