Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

QR code component solution

Arkadiusz Żmudzin•30
@arkus7
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm most proud that I managed to finish this challenge :) Next time, I might separate CSS from the index.html file and maybe use some variables (or even SCSS) for styling.

What challenges did you encounter, and how did you overcome them?

I had a problem with centring the card both vertically and horizontally. I found some articles about using flex to do this, but the default margins and padding messed it up a bit (creating additional space so that scrollbars were active). I've used a "hack" with * to reset those, but I'm unsure if this is the right approach. I've also had an issue with properly sizing the text elements on the card - the style guide said the paragraph size should be 15px, but there was no mention of the size for the header. I had to download the Figma file to check the proper size so I could mirror the design as closely as possible.

What specific areas of your project would you like help with?
  1. I'm not sure if the HTML structure I came up with is the right approach. I tried not to overuse div elements, I reached for tags like main and section to give it more semantics although I worry that this is overkill for the example in the challenge. Any feedback is appreciated.
  2. I had a problem with centring things and I've used flex to solve it - what is the best approach here? I've used height: 100vh on the container to fill the whole viewport so it is also centred vertically - is this how it's supposed to be done?
  3. Is the naming of the classes in the CSS fine? I've always struggled with naming them and I went for naming by the "component" they describe.
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Karol•3,100
    @VillageR88
    Posted about 1 year ago

    Arkadiusz, I sent you the complete solution fix via pull request yesterday, but it seems to have been ignored.

  • Faisal Baig•90
    @Faisalbaig1998
    Posted about 1 year ago

    Nothing

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub