QR Code Component Solution
Solution retrospective
Hi everyone! 👋
I completed the project but I don't know if the codes I wrote are best-practise. It was an enjoyable project. It was exciting because it was my first project. Thank you for the feedback. 💯
If you liked it, please don't forget to touch the heart icon. 🧡 Additionally, I'm very open to learning, so please comment if there's anything I missed. 📩 Thank you in advance.
Happy coding! ⚡
Please log in to post a comment
Log in with GitHubCommunity feedback
- @brsmit1993
Overall your code looks pretty clean and well formatted. A few things I noticed though. The first you were mixing px and em and using them interchangeably. Although this isn't a big deal it's usually best to pick one and stick with it throughout your code. The only exception I would say is using 'rem' or 'em' for fonts and then px for everything else. Another note as well I would avoid using 'em' unless you intend to do it for a specific purpose. em values are relative to the font-size of the nearest parent element, while rem values are relative to the root font-size which is generally 16px. I tend to use 'rem' because I know it will always (rem * root font-size) but with em if you've modified font sizes for any of it's parents it can cause weird and unintended effects if not used carefully. Hope this info comes in handy and if you're interested in learning more about rem or em than this article might be a good place.
https://blog.logrocket.com/using-em-vs-rem-css/
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord