Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component solution using CSS

Yash Goswamiβ€’ 70

@Yash-devasp

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have complete my first challenge on frontendmentor.io and with this I am starting a new journey on this path. I had a lot of fun completing the first assignment.

As I am a beginner and have just started learning about web a couple of days back so I am sure my code can be improved. Please help me in my journey by pointing out ways in which my code can be improved or if there could be a better way to tackle a problem.

Community feedback

Naveen Gumasteβ€’ 10,480

@NaveenGumaste

Posted

Hello Yash Goswami ! Congo πŸ‘ on completing this challenge

Let's look at some of your issues, shall we:

  • Why use <p class="head">Improve your front-end skills by building projects</p> you should use h1 here as it is title of the card

  • the background shadow is very dark so make it more soft

  • Read style-guide and add the font-style and size along with weight

  • Add equal padding or margin for the qr img and the texts

happy CodingπŸ˜€

0

Shashree Samuelβ€’ 9,260

@shashreesamuel

Posted

@Crazimonk I agree with the first bullet point

1
Naveen Gumasteβ€’ 10,480

@NaveenGumaste

Posted

@TheCoderGuru what about others?

0
Shashree Samuelβ€’ 9,260

@shashreesamuel

Posted

@Crazimonk I agree with the rest also 🀣

1
Yash Goswamiβ€’ 70

@Yash-devasp

Posted

@Crazimonk thanks for the suggestion I think it will also improve my accessibility issue also. Thanks for your suggestion.

1
Abhikβ€’ 4,840

@abhik-b

Posted

πŸ‘‹ Hello Yash ,Congratulations on completing your 1st challenge. Your solution is fantastic & it is very responsive πŸ€©πŸ‘Œ

Some of my opinions I am sharing with you :

  • give margin: 0; to *{ } to remove unwanted margin from all elements
  • remove the height from card & give gap:1em to make the card look more like the design
  • your box-shadow is very nice

Very Well Done 🀩 & Please keep coding such amazing solutions πŸ₯³πŸ‘

0

Yash Goswamiβ€’ 70

@Yash-devasp

Posted

@abhik-b Thank you so much for taking the time to go through my code. I will keep in mind your recommendations and improve my code.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord