Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

QR code component solution using flex box and css variables

kailynnelopez•20
@kailynnelopez
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I feel like I used a lot of Divs, were they all necessary? are there any areas where I should have condensed my code?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Leon Pahole•480
    @leonpahole
    Posted over 2 years ago

    Hey Kailynne, nice solution :)

    Regarding your question about using too many div elements, to first give you the precise technical answer, yes, you can do it with less divs. For example, you don't need the div with the "content" class, as it kind of "double-wraps" the card.

    In addition, you could also remove the "text" div, but then you'd have to set max-width: 90% to both text nodes, so it would result in some code duplication - so I'd argue that while the "text" div could technically be removed, it is much better that it is there so you only set max-width: 90% in one place.

    Now, for a more "human" answer, the reality is that the amount of divs you use isn't really that relevant, as long as their usage makes sense to you as the developer. It is true that if you use a lot a lot a lot of elements on the page, the performance of the site will suffer, but here I am referring to huge amount of elements. So I wouldn't stress too much about the number of divs, and instead would focus on making sure that the code is understandable :)

    Some other comments about your code:

    • I noticed that you used font-family on every text node in the css. You can take advantage of CSS inheritance and set the font-family just in the body. Then all children will inherit the font-family. See details about inheritance here.
    • Try using relative units (like rems) instead of absolute units (px) for font sizes. More information in this blog post.
    • Since all of your colors are in CSS variables except for the color of the a element, I would suggest storing that color in a variable as well, to keep things consistent. Good idea on using CSS variables for colors!

    I hope this explanation helps you :)

    Marked as helpful
  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted over 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

    • So fix it by replacing the <div class="card"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    HEADINGS ⚠️:


    • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

    • Every site must want at least one h1 element identifying and describing the main content of the page.

    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub