@nikoescobal
Posted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
Here's some feedback on this solution:
- You should build mobile-first, meaning all your CSS classes should apply to the mobile viewport first, then add media queries to manage the other screen sizes
- It seems like you didn't resize the fonts for mobile view
- Add padding to the text so it doesn't touch the sides of the card.
- Check the report to fix accessibility issues - you currently have 1 listed
I hope this is helpful and all the best with your coding journey!
Marked as helpful
@AgusSaMac
Posted
@nikoescobal Hello, thank you very much for your feedback. I'll apply the changes and have your advice in mind for future projects.
Have a great day!
@nikoescobal
Posted
@AgusSaMac Awesome to hear! It's my pleasure! Hope you have a great day as well! Oh, one last thing -- I highly recommend learning Sass, as this will allow you to nest your CSS classes and keep your code much cleaner/more readable. It's also good because it allows you to mimic the HTML structure in a way that makes it easy to follow/read your code overall.
Cheers, Niko
Marked as helpful
@AgusSaMac
Posted
@nikoescobal Thanks again!
