QR code component

Community feedback

• 

  P

  Thomas Dimnet•250

  @tdimnet

  Posted about 1 year ago

  Hi @RespeitaOPai,

  Nice work with your project! I read both your CSS and HTML code and most of what I saw was really good for a first project!

  Here are some feedback if you want to improve your project:

  • I saw that some part of your CSS was in the HTML file. Here is an example of what I am talking about: <img src="images/image-qr-code.png" alt="qr code" style="width: 90%; ;">. Most of the time, we tend not to use inline style. It can make your code less maintainable.
  • You should add box-sizing: border-box at the top of your CSS file. If you want to learn more about it, here is a great ressource: https://css-tricks.com/box-sizing/
  • Be aware of your indentation. I am thinking of your media queries section in your CSS file.

  Other than that, it's great first project!

  Have a nice day, Tom.

  00