QR Code Component. Used HTML, CSS and Flexbox

Hi, Kirin! 👋

Congratulations on completing your first Frontend Mentor challenge! 🎉 Good job on this challenge! 👏

I would like to recommend is that you could essentially finish this challenge without any media query at all by specifying a max-width on the .container element. Also, I would recommend setting a min-height on the body element instead of a height. Currently on mobile landscape view (360px * 640px) the card gets cut off.

That's it! I hope this helps! Keep up the good work! 👍

Hi Kirin, good job! I took some time to look at your code and have some ideas for improving it:

• add main tag and wrap the card for improve the Accessibility
• remove all margin from .container class because with flex they are superfluous
• instead of using px try to use relative units of measurement -> read here
• as @vanzasetia already said it sets min-height to body instead of height

Overall you did well 😉

Hope this help and happy coding!

Hi Kirin One suggestion that I was given that helped improve the accessibility report was to use things like <main> and <footer> tags, instead of <div> tags. My original had the same accessibility issues as you, but this took care of it.

Thanks for you advice sir. I will follow you recommendations :)