QR code Component using basic HTML, CSS, and flexbox

Solution retrospective
-
I would like to know if my project is in-line with the best practices (E.g. CSS class naming convention, file structure, readme, etc)
-
I would like to know if any features could be added, I have few in my mind like generating custom QR code whenever a user enters their own website, but I'm open to any suggestions :).
Please log in to post a comment
Log in with GitHubCommunity feedback
- @ToHX
Hi there 👋
Some issues I saw
- your CSS class naming could be improved with BEM
- Your img has no alt Attribute
- You have a h3 but no h1
- Font size always in rem
Marked as helpful - @kacperkwinta
Hi!
Some tips for fixing errors in your solution report:
- add
alt=""
tag to image - create
<main>
tag and wrap all other elements into this
Marked as helpful - add
- @cloudyay
Hi Harish
The solution looks great. There is something I would like to know. How were you able to create the white box of almost the same dimensions? Is there a way to figure out what should be the width and height size?
Thanks, Megha
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord