QR code component - using bootstrap

Solution retrospective
What did you find difficult while building the project? No Which areas of your code are you unsure of? No Do you have any questions about best practices? No
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@danielmrz-dev
Hello @Das-02!
Your solution looks great!
I have a suggestion for improvement:
- For semantic reasons, and since that is the main title of the screen, you can replace the
<p>
with<h1>
.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Also, still about semantic HTML, replace
div.card
withmain.card
.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
- For semantic reasons, and since that is the main title of the screen, you can replace the
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord