@romila2003
Posted
Hi Oleh,
Welcome to the frontend mentor community and congratulations for 🎉 for completing your first challenge, the card looks good, and it is great that you used the flex
property to center the card. However, I found some issues I want to address:
- It is best practice to wrap the main content within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- To give your code a cleaner look through less code, you can do something like this:
<main class="container">
<img src="image-qr-code.png" alt="qr-code">
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take you coding skills to the next level</p>
</main>
Overall, great work and wish you the best for your future projects so keep coding 👍.
Marked as helpful
@OlehLy
Posted
@romila2003 Thank you for you feedback 😊