Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

QR Code Component using CSS Flexbox

accessibility
Ozoeze Ugo•10
@Ugonadia
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I will appreciate any feedback on how I could have done this better especially the media queries part of my code.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Aviral Sharma•220
    @aviralsharma07
    Posted over 2 years ago

    Hey, Congratulations on creating this project. Here are my few suggestions for you.

    • Use semantics HTML Tags like <article> to wrap card content then <div>
    • You don't need to wrap the <img> inside an <div> it is not required.
    • Write your CSS in a separate file named styles.css and link it to HTML in the <head> section.
    • Use max-width: 25ch instead of width for .text-class
    • There is no need for a Flex basis multiple times in this project. Refer to this to learn Flexbox: https://css-tricks.com/snippets/css/a-guide-to-flexbox/
    • Use margin-top for spacing between <p> and heading not padding-top.

    Hope it helps. Keep up the good work!

    Marked as helpful
  • Trae Zeeofor•490
    @traez
    Posted over 2 years ago

    Nne welcome to frontendmentor. Github seen. You're doing well. Keep building and learning!

    For starters you can take note of the Accessibility report (2) and HTML validation report (5) outstandings, and start to perfect your craft from there.

    The media query wasn't really good. Responsiveness wasn't neat. But it's your first try and it's allowed. Google and look for an article that explains how to implement media query (when shifting from mobile to desktop and vice versa)

    https://traez.github.io/time-tracking-dashboard-main/ You can check out my latest project and see how the look changes when you toggle mobile and desktop view.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub