Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

QR code component using CSS Grid

Levi Powis•10
@levipowis
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud that I just sat down and built the thing and didn't get bogged down in tutorials or anything. I used Google to find W3Schools, MDN, and blog articles to find what I needed to get it done.

Next time I'd like to start with mobile first and work from there. Also I would like to use CSS variables so I can get used to using them and make it easier to call font colors and families.

What challenges did you encounter, and how did you overcome them?
  1. Making the card and then trying to get the spacing right between the border and the image. Played around with margin and padding with some unexpected results, but I played around with it until it looked right.
  2. Centering the card vertically and horizontally. I chose CSS Grid to do this because it was only three lines of CSS. Wanted something simple to accomplish a simple task. I had trouble getting Flexbox to work for this. I need to learn more about Flexbox in future projects.
  3. The size of the card was smaller than the design image in the mobile view so I had to use a media query at the bottom of the CSS file to make the mobile version look right. Next time I'll start with mobile and work from there.
What specific areas of your project would you like help with?

Mainly how I can structure the code so it looks like production code. What best practices am I not aware of that will help make my code look more professional and easier to read.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Øystein Håberg•13,280
    @Islandstone89
    Posted over 1 year ago

    Hi Levi, here is some feedback. Hope it helps!

    HTML:

    • The alt text must also say where it leads(frontendmentor.io).

    • The text in .attribution are paragraphs, so use the <p> tag.

    CSS:

    • It's good practice to include a CSS Reset at the top.

    • Move background-color to body.

    • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

    • I would move the properties on main to body. Remove the width - block elements are 100% wide by default.

    • align-items: center doesn't do anything unless you declare display: flex.

    • If you wanted to use Flexbox to center the card, you could use the following on the body:

    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100svh;
    
    • Remove the width and height on the card. The web is different from the printed medium - we want our components to be responsive, meaning they can adapt to different screen sizes.

    • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value. Do the same with font-family.

    • You can give padding-left and padding-right the same value by using padding-inline: 1em, for example.

    • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub