qr code component using flexbox

Solution retrospective
#1 - is my html structure correct #2 - how should i define the width of the card itself? 20%, 30% etc..
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Samadeen
Hey JSninjawizard!! Cheers 🥂 on completing this challenge.. . Here are my suggestions 1.You should use <main class="container"> instead of <div class="container">.
-
Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
-
You can also increase and change the color of your headings and paragraph to get a look alike from the design
. Regardless you did amazing.. Happy coding!!!
Marked as helpful -
- @mamba-dev-KE
Hey, impressive implementation here. I had a look at your code and have some recommendations:
- To improve your html structure, consider adding a main tag to hold all the content within body.
- As for the width of the card you can control it using a set-width that is not equal to 100% of the container so that the card does not touch the sides of the screen and a max-width on the card to ensure it does not grow past a set max-width value.
I used these approaches in my QR code solution, you can have a look under my profile.
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord