Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 month ago

QR Code Component using Flexbox and Mobile-First Design

Abdul Subhan•1,580
@Esabdul
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud that I completed this project from start to finish, including solving merge conflicts and fixing deployment issues. Next time, I'll keep the folder structure clean from the beginning and double-check my file paths to avoid broken styles or images.

What challenges did you encounter, and how did you overcome them?

I faced issues with GitHub Pages not showing my CSS and images. The problem turned out to be incorrect file paths that started with slashes. I also had some Git merge conflicts,but I resolved them using GitHub Desktop and the terminal with guidance.

What specific areas of your project would you like help with?

I would appreciate feedback on how I structured my HTML and CSS. I'm especially interested in learning how to better organize small components and follow best practices for readability and maintainability.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Sean Buckle•410
    @seanbuckle
    Posted about 1 month ago

    The project is very well put together.

    In terms of the HTML <div> tags, they should be avoided; instead, use more semantic ones such as <section>. Here is a Link.

    However, only use <div> if there is no other alternative.

    For the CSS, use relative units em rem rather than absolute px for fonts and widths, but also use logical properties like width to inline-size. For classes, keep them concise.

    • Link to Logical properties
    • Link to Relative vs absolute units
    • Link to px to rem converter

    Below is example CSS with slight improvements:

    * {
      padding: 0;
      margin: 0;
      box-sizing: border-box;
    }
    
    body {
      min-block-size: 100dvh;
      padding: 20px;
      display: grid;
      place-items: center;
      font: 400 0.938rem/normal san-serif;
      background-color: hsl(212, 45%, 89%);
    }
    
    img{
      max-inline-size: 100%;
      block-size: auto;
    }
    
    .qr-card {
      max-inline-size: 20rem;
      padding-inline: 16px;
      padding-block: 16px 24px;
      border-radius: 20px;
      display: flex;
      flex-direction: column;
      align-items: center;
      gap: 15px;
      text-align: center;
      background-color: white;
      box-shadow: 0 10px 20px rgba(0, 0, 0, 0.08); 
    }
    
    .qr-card__img {
      border-radius: 10px;
      margin-bottom: 9px;
    }
    
    .qr-card__body {
      padding-inline: 8px;
      color: hsl(220, 15%, 55%);
    }
    

    I used BEM for the classes, but it's not everyone's cup of tea.

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub