QR Code Component using Flexbox and Mobile-First Design

Solution retrospective
I'm proud that I completed this project from start to finish, including solving merge conflicts and fixing deployment issues. Next time, I'll keep the folder structure clean from the beginning and double-check my file paths to avoid broken styles or images.
What challenges did you encounter, and how did you overcome them?I faced issues with GitHub Pages not showing my CSS and images. The problem turned out to be incorrect file paths that started with slashes. I also had some Git merge conflicts,but I resolved them using GitHub Desktop and the terminal with guidance.
What specific areas of your project would you like help with?I would appreciate feedback on how I structured my HTML and CSS. I'm especially interested in learning how to better organize small components and follow best practices for readability and maintainability.
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@seanbuckle
The project is very well put together.
In terms of the HTML
<div>
tags, they should be avoided; instead, use more semantic ones such as<section>
. Here is a Link.However, only use
<div>
if there is no other alternative.For the CSS, use relative units
em rem
rather than absolutepx
for fonts and widths, but also use logical properties likewidth
toinline-size
. For classes, keep them concise.- Link to Logical properties
- Link to Relative vs absolute units
- Link to px to rem converter
Below is example CSS with slight improvements:
* { padding: 0; margin: 0; box-sizing: border-box; } body { min-block-size: 100dvh; padding: 20px; display: grid; place-items: center; font: 400 0.938rem/normal san-serif; background-color: hsl(212, 45%, 89%); } img{ max-inline-size: 100%; block-size: auto; } .qr-card { max-inline-size: 20rem; padding-inline: 16px; padding-block: 16px 24px; border-radius: 20px; display: flex; flex-direction: column; align-items: center; gap: 15px; text-align: center; background-color: white; box-shadow: 0 10px 20px rgba(0, 0, 0, 0.08); } .qr-card__img { border-radius: 10px; margin-bottom: 9px; } .qr-card__body { padding-inline: 8px; color: hsl(220, 15%, 55%); }
I used BEM for the classes, but it's not everyone's cup of tea.
Happy coding!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord