Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using HTML & CSS

@iammukeshmahato

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please give your feedback about my work.

Community feedback

Danilo Blas 6,300

@Sdann26

Posted

Hi Mukesh!

Your work looks pretty good, I would just add a little bit of shadow to the card with box-shadow: 0 4px 12px -4px rgba(0, 0, 0, 0, 0, 0.2).

Regarding the report generated by frontend mentor, if you want to fix the errors you can do it by changing the h3 to h1 since you should always have one and only one h1 per page. And the other error you get because you have a loose div that is the attribution, for this you can give the tag footer, in order to remove all reports.

If you have any doubts or questions do not hesitate to ask :D!

Good Coding!

Marked as helpful

0

@iammukeshmahato

Posted

@Sdann26 Thank you Danilo, Your feedback helped me a lot. I have add box shadow and fixed accessibility issues generated by Frontend Mentor. Thanks you!

1
Danilo Blas 6,300

@Sdann26

Posted

@mukeshmahato843 You are welcome. I would recommend you to clean up your past reports and some of the little color details that I have seen. The idea of eliminating errors in the reports is to build projects with fewer and fewer errors, since in large projects these can escalate.

I saw that in other projects you also had problems with the h1, h2, h3,.... The idea of using them is as titles and subtitles, for example the h1 (which should only be one per page), is the main title and its subtitles would be the h2. The h2 are the main subtitle for the h3 and so on. They work literally like reports that have headings and subheadings per section and so on to encompass more and more precise ideas.

I hope you are doing well, keep it up, good coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord