QR code component using HTML and CSS
Solution retrospective
Hello, I was not sure what would be the appropriate unit to set the width of the outer container, was 30rem a good option? Thank you!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Promisemagoga
You did a great job. Sometimes you have to use your developer eye, more especially if you are not sure about the sizes. Just look at the design and what you have built and just criticise yourself, find something you can fix. If the paragraph on the design is 3 lines and yours is just 1 line, figure out how to do that. Coding is about finding solutions, that's the best part about it.
- @romina-gza
Hey there! 😀 I saw your code, It's very good!
About your question, from my insight '30rem' is fine, but in the 'border-radius' you could change the value to '16px', for makes it similar to the challenge.
Also, for makes that the text looks like the challenge, you could have the 'h1' with a 'font-size' of '2rem' and a 'padding' with these values: '0 1.5rem'.
For last, the paragraph could be a 'font-size' with '1.4rem' and the 'padding' of this could be better with '0 1.5rem 1rem'.
These are little things that I would change, but even is your code is very well. I hope this comment can be useful for you. Happy coding ✨!
- @Alokray007
Hello there 👋
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord