QR code component using HTML and CSS Flex

Solution retrospective
Finally I finished my first challenge on Frontend mentor. Since this challenge does not any advanced implements, I found it quite easy. But I surely have to work on CSS flex more. You can view my code and feel free to leave any advice on how I can improve my code.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Hassiai
Replace<div id="card">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center #card on the page using flexbox, replace the height in the body with min-height: 100vh.
Give h1 and p the same font-size of 15px, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful - @sandro21-glitch
The design is simple and straightforward, with a clear focus on the QR code component.
The color palette is appropriate, and the font choices are legible, but don't like the layout of the text
Overall, the design seems to be well executed and effective in presenting the QR code component.
good luck
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord