Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

QR Code Component using HTML and CSS only,

Muyiwa Saka•30
@MuyiwaSaka
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I'm new to working with the assets given as part of the design brief. I had to launch the png files and then try to get my measurements from there. I also ended up relying on em and vh figures for successfully configuring my design to be responsive.

I used percentages a lot to ensure the design was responsive. What is the best practice with respect to using percentages.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vanza Setia•27,715
    @vanzasetia
    Posted over 2 years ago

    Hi, Muyiwa! 👋

    Congratulations on completing your first Frontend Mentor challenge! 🎉

    I recommend using a code-formatter. This way, your code base will have a consistent format which makes it easier to read the code. I suggest using Prettier as your code-formatter.

    Prettier · Opinionated Code Formatter

    The alternative text of the QR code doesn't need to be uppercased. Also, it should describe the QR code. In this case, it will navigate the users after they scan it. So, the better alternative text can be "QR code to frontendmentor.io".

    Don't use id selectors for styling. There are two reasons for not using ID’s to style content:

    • They mess up specificity because they are too high (the most important reason).
    • They are unique identifiers. So, they are not reusable on the same page.

    Use single-class selectors whenever possible. This can help you produce a low-specificity stylesheet. As a result, it prevents you from having specificity issues.

    Last suggestion, I recommend making the body element as a flex container to place the card in the middle of the page. Then, set min-height: 100vh to make the card vertically centered. After that, remove the relative positioning and margin: auto from the #qrcomponent,

    I hope this helps. Happy coding!

    Marked as helpful
  • Tumelo Mosomane•60
    @Tumelo4
    Posted over 2 years ago

    It will be match easier if you used flex box or grid to center your container. for flex box body { display: flex; justify-content: center; align-item:center; } whatever element inside body will be on center of the body. Also try to separate styling and marks

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub