Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

QR Code Component using HTML and CSS

Gabriel Gasperi Casagrande•80
@gabrielcasag
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I was proud that I was able to code the QR code component in 30 minutes and make the design identical

What challenges did you encounter, and how did you overcome them?

I had to think a little until I realized that I needed to limit the sizes of the elements with max-width so as not to lose the appearance of the prototype

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Øystein Håberg•13,260
    @Islandstone89
    Posted 9 months ago

    Hi Gabriel, good job.

    Here are some suggestions :)

    HTML:

    • <main> holds all of the main content on a page. As a card would likely not be the only component on a page, I would wrap the card content in a <div class="card"> inside of <main>

    • The alt text must also say where it leads(the frontendmentor website). Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    • It's recommended to use classes instead of IDs. This article explains when to use the id attribute.

    CSS:

    • Including a CSS Reset at the top is good practice.

    • Move font-family to body, it's not common to set any styles on html.

    • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

    • Using #container as a selector increases specificity, so I would use body as the selector instead. On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

    • On the card, remove height: auto, it is not needed. Change the max-width to 20rem, which equals 320px.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • letter-spacing must also not be in px. You can use em, where 1em equals the element's font size.

    • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container. Remove height: 100%, it is not needed. You can set height: auto, though.

    • Remove max-width on the image and the text.

    Marked as helpful
  • jonathanudeh•340
    @jonathanudeh
    Posted 9 months ago

    It looks really nice and very identical. kudos. Though it looks like in your css you styled your elements in a disorganized manner. I recently learnt that it is good practice to style from top to bottom. I hope this feedback finds you well.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub