Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

QR code component using html and css

Mary Nabwire•40
@Mary83-ops
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • safdar•130
    @sfdrk
    Posted over 2 years ago

    Hi 👋 I think you could add margin for the main container .... so it will have the space on responsive . Just see in mobile screen it is enlarging to the edge of the screen.

    Marked as helpful
  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted over 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

    • So fix it by wrapping the <div class="card"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
  • Rohit Kumar•560
    @rohitKumar38344
    Posted over 2 years ago

    You have used the wrong syntax on box-shadow property on element having class (.card) It should be like this box-shadow: 0px 3px 25px; . You don't have to seperate the values using commas. Refer to mdn: https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow to read more about box-shadow. Happy Coding :D

    Marked as helpful
  • Boluwatife Bonaventure•690
    @Boyutife
    Posted over 2 years ago

    Hi Mary Nabwire👋. Job well done Congratulations on successfully completing the challenge! 🎉

    I have some additional suggestions for your code that I believe will be of great interest to you.

    HTML 🏷️:

    -This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage. To address this issue, you can review the HTML code of the webpage and add appropriate landmarks where necessary. Some common landmarks that you may want to consider including are: <header> <main> <section> <aside> instead of multiple <div> <span> I hope you find this helpful 😄 Above all, the solution you submitted is great !

    -In your html file you could replace the <div class = 'card'> with <main>

    CSS:

    • You might considering changing the px to rem. rem and em are relative units in CSS, which means that their size is determined by their relationship to other elements in the document. In contrast, px is an absolute unit, which means that its size is fixed and does not change based on any other factors.

    -Overall, while there may be some cases where px is appropriate (e.g., for border widths or image sizes), using relative units like rem or em can help improve the accessibility and responsiveness of your website, as well as make it easier to maintain.

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub