@denielden
Posted
Hi Carlos, great job! Congratulations on completing the challenge.
I had a look at your solution and I have a few suggestions for you:
- add
main
tag and wrap the card for Accessibility - try to remove all
margin
fromcontainer
class and use flexbox to the body for center the card. Read here -> flex guide - also set
heigth
of body to100vh
because Flexbox aligns to the size of the parent container.
Also avoid assigning specific properties to the div
element, rather create a class.
Overall you did well! Hope this help and happy coding!
Marked as helpful
@Karlof99
Posted
@denielden Hi Daniel, Thank you very much for your comments. I find them very helpful. I'll modify my code with these reccomendations and others that have been seen to me. Regards