@Kamlesh0007
Posted
Congratulations on completing the challenge🎉! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add Semantic HTML tags
The HTML structure should be semantically correct. The current structure doesn't provide any semantic information about the content. A better approach would be to use appropriate HTML tags such as <header>, <main>, <section>, <article>, etc. to define the sections of the page.<main> tag to indicate that it represents the main content of the page. You can wrap up .attribution class within <footer> as a part of semantics.Wrapping the .attribution class within a <footer> element is a great way to improve the semantics and structure of your code. here is the code that u need to add to include semantic tags in ur page
<main>
<div class="card-container">
......
</div>
</main>
<footer>
<div class="attribution">
Challenge by
<a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Chu Seng</a>.
</div>
</footer>
Add an alt attribute to the img tag because it provides a text alternative for the image, which is useful in Users with visual impairments rely on screen readers to access the content on web pages. The alt text helps the screen reader software to describe the content of the image, which makes the page more accessible.
<img src="./images/image-qr-code.png" alt="qr-code image" >
