Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component using html5, CSS and media queries

@NicolasGula

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestions on how I can improve are welcome!

Community feedback

ROCKY BARUA 1,090

@Drougnov

Posted

Hello @NicolasGula, you did a marvelous job on the design. It's perfect.

However, you need to improve your Html code's accessiblity. Change/Add these things:

  • Use main, footer, section, article etc. instead of div.
  • Use responsive unit like rem, em instead of px
  • You need atleast one heading in your page. You can change the <p class="title"> to h1 class="title"

Overall, the design looks great. Keep it up. Have a good day, my friend :)

Marked as helpful

1

@NicolasGula

Posted

@Drougnov Thank you so much for the feedback. I appreciate. Take note of your advice.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord