QR code component using only html and css

Solution retrospective
I'm not sure if I'm using semantically correct html tags
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@Islandstone89
Hi, here is some feedback.
HTML:
-
Your HTML looks semantically good, but you need a
<main>
- change the.card
from <article> to <main>. -
Alt text also needs to say where it leads (frontendmentor.io)
CSS:
-
Remove the fixed width on the card.
-
Give the card a max-width in rem to prevent it from getting too big on larger screens.
-
Put
text-align: center
on the body, your text will inherit the value. That's more efficient then setting the same declaration on two different elements.
Marked as helpful -
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord