Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using SASS

#sass/scss
Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I want to improve as a beginner front end developer so any feedback is appreciated😊.

Community feedback

P
Dave Quah 670

@Milleus

Posted

Greetings! 👋 Congratulations on completing the challenge.

I have some suggestions for improvements:

  • Consider using min-height: 100vh in the body instead of height: 100vh. This is because height: 100vh may cause the component to be cut off on smaller screens.

Explanation:

  • If we set height: 100vh on the body, then body will always be 100% viewport’s height regardless of the content. So if the content is more than 100vh, it would be cut off.
  • If we replace this with min-height: 100vh and leave height as its default value, then the body’s height would minimally be at 100vh but can still grow beyond 100vh depending on the content.

I hope this helps and happy coding! 😊

Marked as helpful

0

@jbuast

Posted

@Milleus Thank you so much for taking the time to review my code. New info acquired! Thanks to you! This is noted.

0

@0xabdulkhalid

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.
  • The alt with qr code is not even explaining for what the QR image need to be used.
  • So update the alt with meaningful text which explains like QR code to frontendmentor.io
  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@jbuast

Posted

Thank you so much for the feedback. I will take note and edit it immediately. Hoping to see your feedback to my future projects. 🤗 @0xAbdulKhalid

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord