QR Code component (Vanilla CS + JS + Dark-Light Mode) 🌞🌚

Hi @Lucas👋

I'm Ahmad, A Front-end developer and One of your fans😄

I had a question for you, If you don't mind of course.

Do you get any job offers from frontendmentor?

I'm currently job-hunting, and I was wondering if frontendmentor is worth investing my time in?

Best Regards

Ahmad.

Hi, I love your solution!

The dark mode was awesome!

My only tip is you could improve the acessibility and the html semantics of your app putting the icon used for toggle inside a button tag (with an aria label describing what the button does, e.g. "toggle dark mode").

I love this, Lucas! How fun! Makes me wish I had spent more time having fun with mine, but alas I was too eager to dive into more new projects!

My only suggestion is for your <h1> line of code. It changes color, but that is behavior typical of a button or link. Perhaps change this into a link and add a cursor pointer?

Well done!

@correlucas, Great contributions to the challenge. I like attitudes to learning and putting it to practice. I viewed your task from a mobile and you've done a brilliant job. You reminded me of compressing my codes which I look forward to employing in my next challenge. You did well with the dark mode but I suggest you could use a filter property to change the barcode from blue to gray.

Check my contribution to the challenge for a clear picture.

https://haryorhorlar01.github.io/QR-code-component-challenge/index.html

Hi , great solution I love your approach especially when u decided to add the dark and light mode to spice it up , one thing though it's preferred to cursor:pointer; to show that the toggle is a clickable element.

I really like the approach as the dark mode is a important part of webdesign and digital design in general at the moment. Keep it rocking!

WOW Amazing and very helpful

This is amazing 🤩 this will help a lot

Awesome, great work

This is amazing and inspiring. I love how creatively approached the challenge!

Hi, This is fantastic. I really loved it. I will try to match with your level, though it will take a lot of time and handwork.

hey lucas, congratulations but I didn't find the code😐

this is amazing 😢. i admire your level of intuition.

Hey Lucas, congratulations You did a great job 😉

Let me give you some little tips for optimizing your code:

• you can use article tag for the card container and improve the Accessibility
• add transition to the body as well as you did with card
• instead of using px use relative units of measurement like rem -> read here

You did a great job of both code and design: all very clean and harmonious 😁

Hope this help by Travolgi

Great job, Lucas. and nice work on this challenge ! I liked the dark mode feature especially you said you had zero knowledge in JS. Could you send me the documents you're using to develop your css skills?

Nice work on this challenge 🎉🎉. I love the dark mode feature you added 😇. Could you point me to any resource (preferably an article) that details how to create dark mode in CSS?

hey @Lucas, how are you today? hope you're having a great day/night thanks for always helping out, learning a lot from you I'm on a journey to make all the previous code that I have done on FEM better. Firstly I want to make the works responsive, (but I dont understand because when I inspect my first few works(especially the cards), the position of elements isnt changing as the screen size reduces, so my question is; is it only the font size I'm meant to look at in that condition?)

Hi @Lucas👋

Amazing work! You are the inspiration. I will continue my studies. Someday I will write a similar code! :) I really like changing the colors on the page with the button. Ruszający się obrazek też jest świetny :D