Qr code component vanilla HTML, CSS

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 3 years ago

  Hi Sebastian, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the header tag container of image
  • To make it look as close to the design as possible set width: 22rem; to component class and remove height property
  • replace height with min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  20

  Marked as helpful